-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(addon): cleanup constructors #652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
yousinix
force-pushed
the
refactor/addon/clean-constructor
branch
from
April 24, 2023 15:16
31b78bc
to
63e66d1
Compare
yousinix
changed the title
refactor(addon): cleanup addons constructors
refactor(addon): cleanup constructors
Apr 26, 2023
jenshor
requested changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the developer has to be able to specify the default "setting" on startup.
jenshor
approved these changes
Apr 27, 2023
packages/widgetbook/lib/src/addons/cupertino_theme_addon/cupertino_theme_addon.dart
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lift the
setting
parameters to the addon constuctor itself. This helps making the addon API more readable, and much simpler.Before
After