-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR-263] Polls #57
base: chore/update-api-types
Are you sure you want to change the base?
[FR-263] Polls #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff, just a few questions
/> | ||
{answer.poll_media.emoji && ( | ||
<Styles.AnswerEmoji | ||
emojiName={answer.poll_media.emoji.name ?? "Unknown"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be localised
function durationFormatter( | ||
isShort: boolean, | ||
value: unknown, | ||
lng: unknown, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we using unknown
here?
overflow: "hidden", | ||
}); | ||
|
||
const ANSWER_BAR_Z_INDEX = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add this as a theme zIndex token?
No description provided.