fix: web example ipyleaflet_advanced #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
For basemap variants such as Esri.WorlTopoMap or
Stamen.Watercolor, map url contains {variant} keyword.
When you provide such urls directly to ipyleaflet.TileLayer.element,
the map is not displayed properly.
Fix:
To resolve the issue, url must first be built
via map.build_url() so the {variant} keyword is evaluated
correctly, then the built url is given to TileLayer.
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
For basemap variants such as Esri.WorlTopoMap or
Stamen.Watercolor, map url contains {variant} keyword. When you provide such urls directly to ipyleaflet.TileLayer.element, the map is not displayed properly.
Fix:
To resolve the issue, url must first be built
via map.build_url() so the {variant} keyword is evaluated correctly, then the built url is given to TileLayer.