-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation to details component #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey again @mikegiann01!
Great to see that you got everything working! There are some indentation issues with the docstring, I marked them in the review. Also, the whole string should be de-indented one tab to align with the triple quotes. Hopefully pre-commit won't give any issues this time :)
Hey @mikegiann01! I think the P.S. I merged our master to your branch to update it. You should probably |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for the help, looking to contribute more!! |
I commited a script about the time picker component, i tried creating a new pull request only for this commit but made some mistakes and i am unable to vreate the new pull request. What should i do? |
@mikegiann01 For the PR you should be able to get rid of the last commit by doing |
Thanks a lot for the PR @mikegiann01! We look forward to getting the other one in (and any future ones of course :) ). |
Worked on the issues i was having and commited again.