Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation to details component #644

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

mikegiann01
Copy link
Contributor

@mikegiann01 mikegiann01 commented May 10, 2024

Worked on the issues i was having and commited again.

Copy link
Collaborator

@iisakkirotko iisakkirotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey again @mikegiann01!

Great to see that you got everything working! There are some indentation issues with the docstring, I marked them in the review. Also, the whole string should be de-indented one tab to align with the triple quotes. Hopefully pre-commit won't give any issues this time :)

solara/components/details.py Show resolved Hide resolved
solara/components/details.py Outdated Show resolved Hide resolved
solara/components/details.py Outdated Show resolved Hide resolved
solara/components/details.py Outdated Show resolved Hide resolved
solara/components/details.py Outdated Show resolved Hide resolved
@iisakkirotko
Copy link
Collaborator

Hey @mikegiann01!

I think the pre-commit failure is due to the string block after the beginning being indented one tab too far. Let's hope fixing that makes it happy.

P.S. I merged our master to your branch to update it. You should probably git pull.

Copy link
Collaborator

@iisakkirotko iisakkirotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mikegiann01
Copy link
Contributor Author

Thanks for the help, looking to contribute more!!

solara/components/details.py Outdated Show resolved Hide resolved
@mikegiann01
Copy link
Contributor Author

I commited a script about the time picker component, i tried creating a new pull request only for this commit but made some mistakes and i am unable to vreate the new pull request. What should i do?

@iisakkirotko
Copy link
Collaborator

@mikegiann01 For the PR you should be able to get rid of the last commit by doing git rebase -i HEAD~1 and marking the commit that is show with d or drop. That removes it from your master-branch, and should update (after pushing) this PR. However, before you do that, you should create a new branch for you to open the InputTime-PR from. For that, create a new branch that corresponds to widgetti/master as of right now (probably your best bet is to use git rebase similarly to before) until only the commits present on our master-branch are there. After you've done that, find the SHA of the Created input time component-commit and git cherry-pick that commit over to the new branch. If you run into any other trouble let me know here or on Discord!

solara/components/details.py Outdated Show resolved Hide resolved
@iisakkirotko iisakkirotko merged commit df5ef37 into widgetti:master Jun 6, 2024
23 checks passed
@iisakkirotko
Copy link
Collaborator

Thanks a lot for the PR @mikegiann01! We look forward to getting the other one in (and any future ones of course :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants