Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show AppBar when Tabs is a child of AppBar #656

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix: show AppBar when Tabs is a child of AppBar #656

merged 2 commits into from
Jun 6, 2024

Conversation

iisakkirotko
Copy link
Collaborator

Fixes a bug where, if solara.lab.Tabs was the only child of solara.AppBar, the AppBar would be hidden.

@render Render
Copy link

render bot commented May 21, 2024

Your Render PR Server URL is https://solara-stable-pr-656.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cp6cq463e1ms738e0190.

@iisakkirotko Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite Graphite

@iisakkirotko iisakkirotko mentioned this pull request May 21, 2024
Draft
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from 1f72013 to 51b28c5 Compare May 22, 2024 07:41
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from 51b28c5 to c34291a Compare June 3, 2024 07:13
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from c34291a to 4ce4cf2 Compare June 3, 2024 14:44
maartenbreddels
maartenbreddels reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really a pity the diff is still this large. But a good catch, it's clear to me this is a bug!

solara/components/applayout.py Outdated Show resolved Hide resolved
solara/components/applayout.py Outdated Show resolved Hide resolved
@maartenbreddels maartenbreddels changed the title fix: show AppBar when Tabs are the only children fix: show AppBar when Tabs is a child of AppBar Jun 3, 2024
@iisakkirotko @maartenbreddels
incorporate changes from code review
5b2fff1 
Co-authored-by:  maartenbreddels <maartenbreddels@gmail.com>
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from 504c870 to 5b2fff1 Compare June 4, 2024 08:05
@maartenbreddels maartenbreddels merged commit 2c959a0 into master Jun 6, 2024
24 checks passed
@iisakkirotko iisakkirotko mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartenbreddels maartenbreddels maartenbreddels left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iisakkirotko @maartenbreddels