Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional PE.VersionInformation attributes #31

Merged
merged 4 commits into from
Feb 26, 2023

Conversation

mgreen27
Copy link
Contributor

Resubmitting the PE.VersionInformation schema discussed here -#13

Removed regex requirement, we want to allow any ascii (removed redundant regex).
Added additional optional fields to both dll and host binary.

@mgreen27 mgreen27 mentioned this pull request Dec 19, 2022
@wietze wietze self-requested a review February 26, 2023 15:57
Copy link
Owner

@wietze wietze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mgreen27, thanks for contributing!

@wietze wietze merged commit 2172f45 into wietze:main Feb 26, 2023
@wietze wietze mentioned this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants