-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to calculate pressure drop using Ergun equation #18
Conversation
Thanks. I'll pull down the changes and let you know if I have any questions. |
I ran your code and encountered several issues:
|
Hi. Thanks for the feedback. Regarding your points:
|
Yes, you can remove the numbering. But if you want to use a footnote for a reference it needs to have an underscore such as |
For the Flake8 style, this pressure_drop = 150*mu*(1-epsilon)**2*u0/(dp**2*epsilon**3) + \
1.75*rhof*(1-epsilon)*u0**2/(dp*epsilon**3) should be pressure_drop = 150 * mu * (1 - epsilon)**2 * u0 / (dp**2 * epsilon**3) + \
1.75 * rhof * (1 - epsilon) * u0**2 / (dp * epsilon**3) I am ignoring the |
I'll have to check why my linter isn't signaling that then. I've added commits to fix the reference, toctree, and flake8 issues. Think that covers the problems. |
Thanks, everything looks good. I changed the base branch to |
This is a small pull request to test the git workflow.