Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create recruitment.py #21

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Create recruitment.py #21

merged 3 commits into from
Feb 20, 2019

Conversation

granitz
Copy link
Contributor

@granitz granitz commented Feb 20, 2019

No description provided.

@coveralls
Copy link

coveralls commented Feb 20, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 421

  • 1 of 9 (11.11%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 87.221%
Changes Missing Coverage Covered Lines Changed/Added Lines %
teneto/temporalcommunity/recruitment.py 1 9 11.11%
Totals Coverage Status
Change from base Build 416: -0.2%
Covered Lines: 2662
Relevant Lines: 3052
💛 - Coveralls

@wiheto
Update recruitment.py
8717a09 
Adding imports, pep8, adding shape check. Removing parts from allegiance which seemed incorrect. Making for-loop enumerate
wiheto
wiheto reviewed Feb 20, 2019
View reviewed changes
teneto/temporalcommunity/recruitment.py Outdated
N = len(community)
C = np.unique(community)

MA = module_allegience_matrix(N,C,community)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in this version allegiance takes three inputs, but in the PR #22 it only takes one input. So in my edit, I've removed lines 26,27 and taken away these two inputs.

@wiheto
Copy link
Owner

wiheto commented Feb 20, 2019 •
edited
Loading

Again the same thing here as the previous PR, an addition to the __init__.py and writing a quick test. But I can write this if you want. Just let me know.

@wiheto wiheto mentioned this pull request Feb 20, 2019
Closed
5 tasks
@wiheto wiheto merged commit d996725 into wiheto:master Feb 20, 2019
@granitz granitz deleted the patch-6 branch February 20, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiheto wiheto wiheto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@granitz @coveralls @wiheto