Uncaught TypeError: originalEvent is not a function #505
Assignees
Labels
Comments
|
I've got an implementation for #520 that I think should take care of this. |
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this issue
May 28, 2019
Closes wikimedia-gadgets#520 and wikimedia-gadgets#505. Removes the old "open talk page" sysop option and folds the non-sysop tagging system into a unified `noteToCreator` notification system for both tagfing and deleting. Uses the existing system for tagging to determine whether or not to notify, rather than the bespoke option for `openUserTalk` from wikimedia-gadgets#300; that is, it will notify only if the corresponding box is checked AND (at least one of) the CSD in question is checked in the user preferences. The box is checked by default, unless it finds `$('#delete-reason')` on the page, indicating some sort of XfD or CSD or the like; in the latter scenario, if the box is subsequently checked, there is an additional prompt (this might be a good candidate for removal down the line, but I think it's important to include now, especially since it's a new feature). It uses the existing preference about whether to welcome the user alongside the notification rather than create a separate one just for post-deletion notifications. New templates all listed at [[Template:Speedy deletion deleted]].
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this issue
May 28, 2019
Closes wikimedia-gadgets#520 and wikimedia-gadgets#505. Removes the old "open talk page" sysop option and folds the non-sysop tagging system into a unified `noteToCreator` notification system for both tagfing and deleting. Uses the existing system for tagging to determine whether or not to notify, rather than the bespoke option for `openUserTalk` from wikimedia-gadgets#300; that is, it will notify only if the corresponding box is checked AND (at least one of) the CSD in question is checked in the user preferences. The box is checked by default, unless it finds `$('#delete-reason')` on the page, indicating some sort of XfD or CSD or the like; in the latter scenario, if the box is subsequently checked, there is an additional prompt (this might be a good candidate for removal down the line, but I think it's important to include now, especially since it's a new feature). It uses the existing preference about whether to welcome the user alongside the notification rather than create a separate one just for post-deletion notifications. New templates all listed at [[Template:Speedy deletion deleted]].
|
Solved in #563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I get the below error when (un)checking CSD criteria when multiple is cheched.
It refers to
https://github.com/azatoth/twinkle/blob/b91e9dfdb72e15ed93358e6c2b03ad565e8d66ae/modules/twinklespeedy.js#L501
The text was updated successfully, but these errors were encountered: