friendlytag: Put tags under csd and prod nominations (not afd yet) #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses regex from the speedy module, partial fix for wikimedia-gadgets#237. AfD is NOT supported because it doesn't lead with a template, but rather with a <!-- comment. This regex was already enormous and unwieldy, and is now even worse. It'd be good to clean it up, but even modern js isn't fully pcre, so there's no /x to help us out.
|
This should do the trick for CSD and PROD templates, but AfD is tricky as it doesn't use a template to start off, but rather a comment:
This poses all sorts of annoyances, since that comment is followed by a template and then two more comments, one of which has template code inside of it. |
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Apr 11, 2019
Continues on wikimedia-gadgets#541, closes wikimedia-gadgets#237. Makes regex far more readable. Co-authored-by: Amory Meltzer <Amorymeltzer@gmail.com> Co-authored-by: Siddharth VP <siddharthvp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses regex from the speedy module, partial fix for #237. AfD is NOT supported because it doesn't lead with a template, but rather with a <!-- comment.
This regex was already enormous and unwieldy, and is now even worse. It'd be good to clean it up, but even modern js isn't fully pcre, so there's no /x to help us out.