speedy: disable G8 and T2 rationale when deleting #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like G7 (disabled in 7191d4c as part of wikimedia-gadgets#300), the rationales here aren't used. G8 is different from G7, though, in that it uses `rationale` for the tag, but `summary` for the deletion log. We could instead set `currentParams.summary` to `currentParams.rationale` for G8 (and hide on multiple?), but the reality is that G7 and G8 are two of the CSD areas that a custom summary is least useful for. Moreover, we only have this for the generic G8 option, and doing so would mean removing the standard G8 text (barring some moderate edits to the template). T2, on the other hand, is just like G7, in that the summary takes no parameter. We could, of course, change either template, forcing them to take a `{{{rationale}}}` (and/or `{{{summary}}}`), but not sure that's super helpful here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like G7 (disabled in 7191d4c as part of #300), the rationales here aren't used. G8 is different from G7, though, in that it uses
rationalefor the tag, butsummaryfor the deletion log. We could instead setcurrentParams.summarytocurrentParams.rationalefor G8 (and hide on multiple?), but the reality is that G7 and G8 are two of the CSD areas that a custom summary is least useful for. Moreover, we only have this for the generic G8 option, and doing so would mean removing the standard G8 text (barring some moderate edits to the template). T2, on the other hand, is just like G7, in that the summary takes no parameter.We could, of course, change either template, forcing them to take a
{{{rationale}}}(and/or{{{summary}}}), but not sure that's super helpful here; I can start a discussion on the meta talkpage about syncing/unifying some of these.