Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit dialog when users accidentally quit new topic #3674

Merged
merged 13 commits into from
Nov 30, 2022

Conversation

sharvaniharan
Copy link
Contributor

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/java/org/wikipedia/talk/TalkReplyActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/org/wikipedia/talk/TalkReplyActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/org/wikipedia/talk/TalkReplyActivity.kt Outdated Show resolved Hide resolved
@sharvaniharan
Copy link
Contributor Author

@cooltey @dbrant This is ready for review - passed design review.

@dbrant dbrant merged commit 1a50e85 into main Nov 30, 2022
@dbrant dbrant deleted the T321269_exit_dialog_design branch November 30, 2022 20:08
sharvaniharan added a commit that referenced this pull request Dec 2, 2022
* main:
  Update test releated libraries version (#3708)
  Bump versionCode. (#3707)
  Exit dialog when users accidentally quit new topic  (#3674)
  Update the empty states in the talk page (#3676)
  Add missing preview funnel call.
  Tweak: shareable reading list design feedback (#3697)
  Remove search suggestion related code from the app (#3705)
  Remove unnecessary word from a message (#3704)
  Update RxJava to 3.1.5. (#3702)
  Localisation updates from https://translatewiki.net. (#3701)
  Update shareable reading list strings for translation (#3703)
  Update strings for shareable reading list (#3700)
  Split off Reading Lists surveys into two independent surveys. (#3698)
  Localisation updates from https://translatewiki.net.
  Fix: don't check for explicit storage permission in API 33+. (#3693)
  Factor out a string constant. (#3694)

# Conflicts:
#	app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.kt
#	app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.kt
#	app/src/main/res/layout/item_reading_list.xml
#	app/src/main/res/values-qq/strings.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants