Tweak: shareable reading list design feedback #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cooltey Are you updating all of the language translations on TranslateWiki? (if not, they will all be overwritten on the next TWN sync.) |
|
@cooltey All of these changes look ok to me -- Feel free to merge and re-release to beta if the design is approved before Wed. |
sharvaniharan
added a commit
that referenced
this pull request
Dec 2, 2022
* main: Update test releated libraries version (#3708) Bump versionCode. (#3707) Exit dialog when users accidentally quit new topic (#3674) Update the empty states in the talk page (#3676) Add missing preview funnel call. Tweak: shareable reading list design feedback (#3697) Remove search suggestion related code from the app (#3705) Remove unnecessary word from a message (#3704) Update RxJava to 3.1.5. (#3702) Localisation updates from https://translatewiki.net. (#3701) Update shareable reading list strings for translation (#3703) Update strings for shareable reading list (#3700) Split off Reading Lists surveys into two independent surveys. (#3698) Localisation updates from https://translatewiki.net. Fix: don't check for explicit storage permission in API 33+. (#3693) Factor out a string constant. (#3694) # Conflicts: # app/src/main/java/org/wikipedia/readinglist/ReadingListItemView.kt # app/src/main/java/org/wikipedia/readinglist/ReadingListsFragment.kt # app/src/main/res/layout/item_reading_list.xml # app/src/main/res/values-qq/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T316834#8409619