Factor out kafka async wrapper code #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code has been moved to a separate module: @wikimedia/node-rdkafka-factory and added here as an optional dependency. The default-eventgate factory will only attempt to require this if kafka.conf is set. By factoring out this code, custom EventGate implementations can require is separately from EventGate to create their own Kafka produce functions. Bug: T266058
|
@wikimedia/node-rdkafka-factory initial commit for review is here: https://gerrit.wikimedia.org/r/c/node-rdkafka-factory/+/637026 We need to merge and publish that before this is merged. |
Pchelolo
suggested changes
Oct 28, 2020
| */ | ||
| function makeProduce(options, producer) { | ||
| async function makeKafkaProduce(options, logger, metrics) { | ||
| const kafka = require('node-rdkafka-factory'); |
There was a problem hiding this comment.
maybe wrap in try-catch and re-throw with a nice error message and a hint to install the dependency?
There was a problem hiding this comment.
I think in this case the Error that is thrown is decent (and standard) when a dependency is not installed.
Bug: T266058
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been moved to a separate module:
@wikimedia/node-rdkafka-factory
and added here as an optional dependency. The default-eventgate
factory will only attempt to require this if kafka.conf is set.
By factoring out this code, custom EventGate implementations
can require is separately from EventGate to create their own
Kafka produce functions.
Bug: T266058