Upgrade to Symfony 4.4 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwilson
force-pushed
the
symfony-4-4
branch
6 times, most recently
from
45e9898
to
2c6982c
Compare
* Updated Symfony packages to `4.4.*`. * Changed from the deprecated DebugClassLoader. * Removed the deprecated WebserverBundle, in favour of the Symfony local server. * Removed app_dev.php check for HTTP_X_FORWARDED_FOR header, so it works with the Symfony local server. * Removed `./var` directory from the repo, to match current Symfony practice. It'll be created at runtime. * Increased the minimum version (and platform config) to PHP 7.3, in line with what's in production. * Remove deprecated `array_key_exists()`. * Add TransformationFailedException to the EventType data transformer. * Fix Travis configuration. Bug: https://phabricator.wikimedia.org/T275463
samwilson
force-pushed
the
symfony-4-4
branch
from
2c6982c
to
7e85c1d
Compare
|
Ah, the README is slightly out of date now (i.e. PHP 7.2). Can be part of the next PR, no rush. Probably don't need to indicate the minimum PHP version anyway or even MySQL as that's implied by composer.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.4.*../vardirectory from the repo, to match current Symfony practice. It'll be created at runtime.array_key_exists().Bug: https://phabricator.wikimedia.org/T275463