Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Does not work with stylelint 16 #126

Closed
pmweeks98 opened this issue Dec 18, 2023 · 2 comments · Fixed by #127
Closed

Does not work with stylelint 16 #126

pmweeks98 opened this issue Dec 18, 2023 · 2 comments · Fixed by #127

Comments

@pmweeks98
Copy link

The upgrade to stylelint 16 deprecates commonjs api

@HolgerJeromin
Copy link

But it is still usable as seen in this partial json:

{
    "devDependencies": {
        "grunt": "1.6.1",
        "grunt-stylelint": "0.19.0",
        "stylelint": "16.0.2",
        "stylelint-config-standard": "35.0.0"
    },
    "overrides": {
        "grunt-stylelint": {
            "stylelint": "15.x || 16.x"
        }
    },
    "stylelint": {
        "extends": [
            "stylelint-config-recommended"
        ],
        "rules": {
            "selector-max-id": 0
        }
    }
}

@slolo2000
Copy link

Hello,

I also have problems when trying to update Stylelint from v15 to v16

As you can see below, grunt-stylelint works very well with current packages version:

Package Current Wanted Latest Location Depended by
stylelint 15.11.0 15.11.0 16.1.0 node_modules/stylelint test
stylelint-config-standard 34.0.0 34.0.0 36.0.0 node_modules/stylelint-config-standard test

I try to install the last version of Stylelint and I have some warnings

`D:\test>npm install stylelint@16.1.0
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: sitebuildsystem@1.0.0
npm WARN Found: stylelint@15.11.0
npm WARN node_modules/stylelint
npm WARN peer stylelint@"15.x" from grunt-stylelint@0.19.0
npm WARN node_modules/grunt-stylelint
npm WARN dev grunt-stylelint@"^0.19.0" from the root project
npm WARN 1 more (the root project)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer stylelint@"15.x" from grunt-stylelint@0.19.0
npm WARN node_modules/grunt-stylelint
npm WARN dev grunt-stylelint@"^0.19.0" from the root project

added 29 packages, removed 37 packages, changed 6 packages, and audited 442 packages in 6s

88 packages are looking for funding
run npm fund for details

found 0 vulnerabilities`

But when I try to install "stylelint-config-standard", I have these error messages:

`# npm resolution error report

While resolving: grunt-stylelint@0.19.0
Found: stylelint@16.1.0
node_modules/stylelint
dev stylelint@"^16.1.0" from the root project
peer stylelint@"^16.1.0" from stylelint-config-standard@36.0.0
node_modules/stylelint-config-standard
stylelint-config-standard@"36.0.0" from the root project

Could not resolve dependency:
peer stylelint@"15.x" from grunt-stylelint@0.19.0
node_modules/grunt-stylelint
dev grunt-stylelint@"^0.19.0" from the root project

Conflicting peer dependency: stylelint@15.11.0
node_modules/stylelint
peer stylelint@"15.x" from grunt-stylelint@0.19.0
node_modules/grunt-stylelint
dev grunt-stylelint@"^0.19.0" from the root project

Fix the upstream dependency conflict, or retry
this command with --force or --legacy-peer-deps
to accept an incorrect (and potentially broken) dependency resolution.
`

Is grunt-stylelint really compatible with the last version of stylelint?

Thanks in advance for your help.

jdforrester added a commit that referenced this issue Jan 9, 2024
This breaks Node 16 support as well, sadly, but we can't have
everything.

Fixes #126
jdforrester added a commit that referenced this issue May 3, 2024
This breaks Node 16 support as well, sadly, but we can't have
everything.

Fixes #126
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants