Fix route parsing when concrete and wildcard paths overlap #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a node tree from a set of paths, unrelated paths
were incorrectly coalesced (or not, depengin on path order). E.g.
path 1: /{var}/bar
path 2: /foo/baz
Expected: { foo: { baz: {} }, '*': { bar: {} } }
Actual: { '*': { bar: {}, baz: {} } }
Use exact the new match exactness parameter in Node.getChild
to prevent this.
|
LGTM. We also need to bump the swagger-router dependency to ^0.7.0 (already published, v0.7.1 currently a PR), and should probably release a new minor hyperswitch version. |
|
Dep bumped and new version released in #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a node tree from a set of paths, unrelated paths
were incorrectly coalesced (or not, depengin on path order). E.g.
Use exact the new match exactness parameter in Node.getChild
to prevent this.
The swagger-router part of the patch is wikimedia/swagger-router#56.