-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Present "System input method" option as a "Disable input method" action #20
Comments
This also causes bug while alternating between languages. http://awesomescreenshot.com/0c6k874eb Steps to reproduce :
|
@srikanthlogic This bug is about changing the label of "System input method". Yours is separate bug. File it as different issue. Also make sure that you validate it against the latest source code. |
@pauginer, where you would suggest the 'Disable input methods' link should be placed when we need to show it ? At present it is at bottom of the IMs available for a selected language. Do you want to it to be there only ? Also, when you want to style it as link, you want it to be styled just like 'Help' link at the bottom ? |
…em input method. - Caption change for action menu : Instead of 'System input method' it is called 'Disable input methods'. - It is only shown when some other input method has been selected, so that user can disable that input method. - It is shown as menu link, like 'Help' menu item. - Behaviour with respect to shortcut 'CTRL+M' is as demanded. Actually, there is no specific code change required here. - Last requirement to show 'No input methods available' when applicable is NOT implemented in this commit.
When such scenario is possible ? Wouldn't all languages will have at least one input method ( and only then it will qualify to be in the list of languages) ? |
With the disabling of IME, we went in a different direction of the one described above. Applications integrating jqueryIME (e.g., MediaWiki), may want to support both (a) disable IME effects but keep the menu, and (b) remove completely the menu. The two kinds of disabling were presented in a different way in the menu:
Once both scenarios were considered, the issue I initially reported should have been closed. |
I see. Which issue takes care of the re-envisioned scenario ? Do we have the stoked keyboard icon ? I guess we can present aforementioned as configuration options while initiating a plugin. |
The disabling functionality and the stroked keyboard are added by the host application. For the case of the ULS, they are added by the MediaWiki extension. Maybe that can be moved to jquery.IME and allow to be enabled on creation. @santhoshtr can probably provide more info on whether this approach is preferred or not from an architectural point of view. |
Presenting "System input method" as an input method option is technically correct, but from the user perspective the main function for this option is to disable any input help and can be presented as such (and only when it is needed):
The text was updated successfully, but these errors were encountered: