-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sending the number of lcd columns as a parameter #168
Conversation
This is needed for https://phabricator.wikimedia.org/T76196 and may also nbe useful for many other features.
@@ -153,8 +153,7 @@ | |||
*/ | |||
renderRegions: function () { | |||
var lcd = this, languages, | |||
items = lcd.options.itemsPerColumn, | |||
columns = 4; | |||
items = lcd.options.itemsPerColumn; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels inconsistent to me to assign items but not columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll probably remove the items variable.
Are you planning to do number of columns selection outside ULS? Wouldn't it be better inside ULS? |
That search icon need a litle bit of padding at left - Now it touch the border. |
Allow sending the number of lcd columns as a parameter
This is needed for https://phabricator.wikimedia.org/T76196
and may also be useful for many other features.