added article topic #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaranto
requested changes
Jun 12, 2024
liftwing/models/article_topic.py
Outdated
Comment on lines
5
to
12
| lang: str = Field(..., | ||
| title="Language code of the wiki", | ||
| description='A string representing the language code related to the target ' | ||
| 'wiki. Example: "en" for English Wikipedia.',) | ||
| rev_id: int = Field(..., | ||
| title="Revision ID of the edit", | ||
| description="The revision id for the wiki identified by the lang parameter.", | ||
| gt=0) |
There was a problem hiding this comment.
These are not the correct parameters. Please visit the API docs page for more info.
liftwing/models/article_topic.py
Outdated
Comment on lines
18
to
19
| api_documentation_url="https://api.wikimedia.org/service/lw/inference/v1/models/outlink-topic-model:predict", | ||
| wmf_model_card_url="https://meta.wikimedia.org/wiki/Machine_learning_models/Proposed/Multilingual_readability_model_card" |
There was a problem hiding this comment.
Please update with the proper urls.
The model card is here
|
Covered by #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a sample pull request before I make pull request for the rest. Before you approve can you tell me why "from .liftwing_model import LiftwingModel, ModelMetadata" doesn't work on my machine?