-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a11y testing to pixel #196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardwang
force-pushed
the
bernard/wmf-a11y
branch
from
August 11, 2023 22:26
96591e3
to
111c05e
Compare
montehurd
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bernardwang
Sorry for delay! Seems to run fine on my machine
Could the Dockerfile be updated to use this?
It's not a dealbreaker, just curious.
@montehurd done! |
moabualruz
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds ability to test for a11y errors to pixel.
a11y-regression
docker imagepa11y
library to run automated a11y testsNotes
At some point, it might make sense to factor out the part of pixel that creates docker containers to compare patches. That logic is what's primarily being leveraged for this new feature, and having a generic tool for comparing patches could be useful for other applications as well.
How to test
The
-a
or--a11y
flag is used to run a11y tests instead of visual tests.Run the following to see what a a11y regression would look like
Run the following to see what a a11y improvement would look like
Run the following to see what no change would look like