Allow scenarios for logged in users #2
Conversation
jdlrobson
force-pushed
the
login
branch
3 times, most recently
from
4f2f7f3
to
c3fd2b2
Compare
|
Latest patch seems more stable - using onBefore instead of onReady. |
jdlrobson
force-pushed
the
login
branch
2 times, most recently
from
ce41b5b
to
b76b2fd
Compare
|
Thank you for working on this. I'm still investigating the cause, but I've noticed the following error message 2 out of 3 runs of |
src/engine-scripts/puppet/scroll.js
Outdated
| @@ -0,0 +1,5 @@ | |||
| module.exports = (page) => { | |||
| page.evaluate( () => { | |||
There was a problem hiding this comment.
I don't know why but i was getting a timeout with this, presumably because it never resolved
There was a problem hiding this comment.
It happens infrequently but definitely happens for me:
Not sure why this is yet as the adding async/await didn't seem to matter.
The other issue I'm seeing is the sticky header tests aren't showing the sticky header for me:
There was a problem hiding this comment.
Okay, FINALLY worked this one out. I needed to return true in page.evaluate
Pushed new patch.
There was a problem hiding this comment.
For some reason, I'm still getting the timeouts:
I wonder if there's something wrong with the server or the mediawiki config used that is causing those. Hopefully, I'll have some time today to dig deeper in this
|
Was this with the version of the patch using onReady? I was getting those errors with that but not onBefore |
|
@jdlrobson Yes, it's with commit 91b4786 . But it might be due to the await question I posted above |
|
Sticky header shouldn't be showing on tablet view. Are you not seeing it on the desktop breakpoint? |
|
Ah good point. I see the following at the "desktop" breakpoint (not to be confused with the "desktop-wide" which shows the sticky header). Presumably at this breakpoint we shouldn't show the sticky header but it looks like our latest TOC styles are not equipped to handle this right now as there is a large gap where the sticky header would otherwise go:
|
nicholasray
force-pushed
the
login
branch
5 times, most recently
from
876ac4a
to
a82eade
Compare
|
@jdlrobson I tried an experiment with the last commit to see how much faster it would be to use an already retrieved cookie without an expiration (from my understanding). The tests are consistently 10-15 seconds faster compared to the previous commit which uses the login page. I really like the improvement in speed. What do you think? |
No description provided.