Change default configuration to reflect moderator tools change #37
Conversation
In T308675 a change was made to Minerva. This results in false positives in our reports, so let's fix those
|
Doesn't seem to be working. Any idea why? |
|
Looking into it now... |
|
Should be fixed now. I think it was from us upgrading docker compose to a new major version today while the containers were running. I ran |
|
Nice.. but now it's picking up a table of contents regression (!? ) https://pixel.wmcloud.org/echo/index.html :) |
|
I think it's legit as I can reproduce it locally as well. It doesn't look like we have a test in the desktop group that shows the sidebar and TOC together so I think that why it's not failing over there |
|
@jdlrobson Is the following expected from the echo changes/tests? It looks like this test is a pass because the diff % is only 0.02% |
|
Not expected, but I'd be more suspicious that this user is not setup correctly. Will dig into this tomorrow. |
This is in response to #37 (comment) where the echo group tests were catching a regression that the desktop group did not catch. Also: * Revise previous tests that use the `Test` page to use the `html` selector for better visibility * Remove the usermenu-closed hashtag as this is the default state
This is in response to #37 (comment) where the echo group tests were catching a regression that the desktop group did not catch. Also: * Revise previous tests that use the `Test` page to use the `html` selector for better visibility * Remove the usermenu-closed hashtag as this is the default state
|
fyi regarding the TOC regression, I added a test to the desktop group [1] that shows the sidebar open with the TOC so this will now be failing in the desktop group as well [1] #38 |
In T308675 a change was made to Minerva. This results in false
positives in our reports, so let's fix those
Since the Echo change is critical to QA I think it makes sense to update this in Pixel to reduce the noise level, what do you think?