Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce noise level in Echo tests #45

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Reduce noise level in Echo tests #45

merged 2 commits into from
Jun 23, 2022

Conversation

jdlrobson
Copy link
Member

Fixex: T310811

@nicholasray
Copy link
Contributor

I need to look into this more, but I'm noticing running ./pixel.js reference -g echo followed by ./pixel.js test -g echo will pretty consistently lead to differences that I don't notice on the main branch:

Screen Shot 2022-06-22 at 5 24 09 PM

nicholasray
nicholasray reviewed Jun 23, 2022
View reviewed changes
configEcho.js Outdated
@@ -67,6 +67,16 @@ const makeScenarios = ( hashtags, queryString, additionalConfig = {} ) => {
test.hashtags
).join( ' ' );
return Object.assign( {
hideSelectors: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using removeSelectors here seems to prevent the issue I was noticing earlier, although I'm still not sure why it's happening

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found garris/BackstopJS#941

@nicholasray nicholasray merged commit 261a8ad into wikimedia:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasray nicholasray nicholasray left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdlrobson @nicholasray