Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the .test.local uri massaging in web.js #100

Merged
merged 4 commits into from
Dec 31, 2014
Merged

Conversation

earldouglas
Copy link
Contributor

Turns out we don't need to check for .test.local all over the place -- just in web.js.

@earldouglas
Copy link
Contributor Author

The test failure in Travis is benign, but I can't tell Travis to re-run the build.

@d00rman
Copy link
Contributor

d00rman commented Dec 31, 2014

Right. At least something like /\/en.wikipedia.test.local\//. Also, I'm not sure we need the g modifier, since we can be fairly certain the domain is not repeated.

@earldouglas
Copy link
Contributor Author

Now that #101 is in, Travis should be happier with this PR...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) when pulling a7bbe77 on test-dot-local into c075063 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) when pulling 27fbb70 on test-dot-local into c075063 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) when pulling ac96275 on test-dot-local into c075063 on master.

@gwicke
Copy link
Member

gwicke commented Dec 31, 2014

@earldouglas +1 from me, but I'll leave the merge to you as I added my two ¢ as well.

earldouglas added a commit that referenced this pull request Dec 31, 2014
Unify the .test.local uri massaging in web.js
@earldouglas earldouglas merged commit 044a225 into master Dec 31, 2014
@earldouglas earldouglas deleted the test-dot-local branch December 31, 2014 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants