-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the .test.local uri massaging in web.js #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failure in Travis is benign, but I can't tell Travis to re-run the build. |
Right. At least something like |
earldouglas
force-pushed
the
test-dot-local
branch
from
December 31, 2014 16:39
c543f1f
to
e120893
Compare
Now that #101 is in, Travis should be happier with this PR... |
gwicke
force-pushed
the
test-dot-local
branch
from
December 31, 2014 21:41
27fbb70
to
ac96275
Compare
@earldouglas +1 from me, but I'll leave the merge to you as I added my two ¢ as well. |
earldouglas
added a commit
that referenced
this pull request
Dec 31, 2014
Unify the .test.local uri massaging in web.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we don't need to check for
.test.local
all over the place -- just in web.js.