Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public documentation for Accept-Language header #1011

Merged
merged 3 commits into from
Jul 30, 2018

Conversation

Pchelolo
Copy link
Contributor

WIP until we enable it for everything.

cc @wikimedia/services

Change-Id: I152fdc47d311213a5764ce8d0ea29537896e741e
@Pchelolo Pchelolo requested a review from d00rman June 25, 2018 17:14
v1/content.yaml Outdated
in: header
description: >
The desired language variant code for wikis where LanguageConverter is enabled.
Example: `sr-el` for latin trascription of the Serbian language.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Latin, * transcription

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't quite understand what you meant here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Latin" should be upper case. "trascription" is a typo, missing an n. Should be "transcription".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh.. didn't notice the typo, so the * made me confused. Sorry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, I should have been clearer, sorry. :-)

v1/content.yaml Outdated
in: header
description: >
The desired language variant code for wikis where LanguageConverter is enabled.
Example: `sr-el` for latin trascription of the Serbian language.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here and below.

@d00rman d00rman merged commit 4784146 into wikimedia:master Jul 30, 2018
@d00rman d00rman added the API label Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants