Add tests for offline mode Web request blocking #103
Conversation
This revealed a couple of issues with the way we were enabling offline mode in our tests, the way we were handling offline requests to be blocked, and the way we respond to blocked requests. All have been fixed and are now under test.
earldouglas
changed the title
earldouglas
changed the title
| }); | ||
| it('should not allow latest content retrieval from storage', function() { | ||
| this.timeout(20000); | ||
| return assert.fails( |
There was a problem hiding this comment.
Why are we using assert.fails here,
Why not just return preq.get(...).then(function(e){assert.deepEqual(e.status, 500)}) ?
There was a problem hiding this comment.
Because .then(function(e) would not run -- it would be shortcutted by the throwing of e, so we need to wrap the whole thing in a try/catch, which is what assert.fails helps us do.
There was a problem hiding this comment.
Ah, thats really useful, thanks for the explanation.
|
You can turn these off if you want https://travis-ci.org/wikimedia/restbase/jobs/45710252#L328? (if they are not logging some useful info, they make test look uglier ;) ) |
|
@HardikJ How do I change the logging level (i.e. to hide |
|
one way would be by changing the logging level to 'fatal' when running tests in offline mode |
|
Where in the code can I do this? Is it part of the |
|
Ah, of course. Thanks! |
Add tests for offline mode Web request blocking
This revealed a couple of issues with the way we
were enabling offline mode in our tests, the way
we were handling offline requests to be blocked,
and the way we respond to blocked requests. All
have been fixed and are now under test.