Improve content negotiation tests for better coverage #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d00rman
reviewed
Sep 26, 2018
| @@ -42,10 +49,11 @@ describe('Content negotiation', function() { | |||
| const wrongContentTypeAccept = currentParsoidContentType | |||
| .replace(/text\/html/, 'application/json') | |||
| .replace(/\d+\.\d+\.\d+"$/, `${PARSOID_SUPPORTED_DOWNGRADE}"`); | |||
| console.log(wrongContentTypeAccept); | |||
Change-Id: I82548dba5eaf141b681723aea5d5fc323e3b3dee
d00rman
force-pushed
the
test_improvements
branch
from
de754e6
to
c647633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of buggy misleading tests fixed.
cc @wikimedia/services