Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed mocha-eslint and eslint-config-node-services dependencies. #1093

Merged
merged 5 commits into from
Jan 25, 2019

Conversation

hknustwmf
Copy link
Contributor

No description provided.

.eslintrc.yml Outdated Show resolved Hide resolved
.eslintrc.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@d00rman d00rman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! One small nit in-lined, otherwise LGTM

maintenance/generate-wikimedia-domain-config.js Outdated Show resolved Hide resolved
@berndsi
Copy link
Contributor

berndsi commented Jan 25, 2019

Indentation looks good to me.

The only thing I would change is
"operator-linebreak": [ "error", "after" ],
to
"operator-linebreak": [ "error", "before" ],
since it's easier to see an operator at the beginning of the line than at the end, so one quickly sees that the line is a continuation.

@Pchelolo Pchelolo merged commit ebdccb7 into wikimedia:master Jan 25, 2019
@d00rman
Copy link
Contributor

d00rman commented Jan 27, 2019

since it's easier to see an operator at the beginning of the line than at the end, so one quickly sees that the line is a continuation.

I tangentially agree, but we've gone with the former everywhere else, so let's keep it consistent.

@berndsi
Copy link
Contributor

berndsi commented Jan 27, 2019

Yeah, I tend to agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants