Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open questions:
vary
that we want to store and return back by which are not valid HTTP request headers.content-type
, we will automatically parse the incoming data stream and will need to re-serialize it. So should we only supportapplication/octet-stream
as a content type and provide the actual content-type inx-rv-content-type
header? if yes - we should return the data with the same header. Alternatively, we can add a patch to hyperswitch to NOT deserialize content and always store is as a Buffer and use proper client-provided content type. Doing so will basically make us reimplement kask here, which we did not want to do and might be to much work for an intermediate solution.