Proton: Support additional options #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support format and device type parameters in the RESTBase public PDF rendering API Bug: T226677
Pchelolo
reviewed
Jul 2, 2019
v1/pdf.yaml
Outdated
| @@ -12,7 +12,7 @@ info: | |||
| name: Apache licence, v2 | |||
| url: https://www.apache.org/licenses/LICENSE-2.0 | |||
| paths: | |||
| /pdf/{title}: | |||
| /pdf/{title}/{format}/{type}: | |||
There was a problem hiding this comment.
We cant really do this, this is not backwards compatible so we will break all the existing clients. Both format and type should be optional, this this needs to be split into 3 separate routes. Also, need to document the defaults for the optional parameters.
… the new variations and document default options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support format and device type parameters in the RESTBase public PDF
rendering API
Bug: T226677