T241756: Parsoid cleanup #1236
Merged
T241756: Parsoid cleanup #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarakosi
force-pushed
the
parsoid-cleanup
branch
from
12b0170
to
98926fd
Compare
Pchelolo
suggested changes
Jan 6, 2020
clarakosi
force-pushed
the
parsoid-cleanup
branch
from
98926fd
to
8e689c0
Compare
Pchelolo
approved these changes
Jan 6, 2020
|
LGTM. Now we also need a patch for the deploy repo https://gerrit.wikimedia.org/r/admin/projects/mediawiki/services/restbase/deploy since we've renamed a config variable. Ping me on IRC if it's not clear what's going on in that repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.