Create GitHub actions #1241
Create GitHub actions #1241
Conversation
.github/workflows/nodejs.yml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [6.x, 10.x] |
There was a problem hiding this comment.
Should probably initiate testing on 12.x at some point.
|
This is quite the set of tests! |
hehe, it's mostly a version/configuration matrix.. If only I could make it work... btw, I'm impressed with GH actions, I've spent no more then 15 minutes on it and it's almost at a working state. Very nice. |
| @@ -1,12 +1,16 @@ | |||
| name: Node.js CI | |||
|
|
|||
| on: [push,pull_request] | |||
| on: | |||
There was a problem hiding this comment.
You can simplify this down to just on: [push,pull_request] unless non-master patches happen a lot?
There was a problem hiding this comment.
In that case it runs both 'push' and 'pull_request' if the development branch is in upstream and not in the fork as it is the case with this one. We usually don't do it, this time it happened cause I've used GitHub UI to create the actions file, but being explicit wouldn't hurt imho
Change-Id: I1c7b35582bd90009fca9903ab6e047aaaffebeb1
Pchelolo
force-pushed
the
github_actions
branch
from
1f30ba3
to
7c9f7b0
Compare
Change-Id: Id644c02cfdebc54a6373d27e8b942fcdefbe8ff2
|
Hmmm... I don't see a way to only rerun failed jobs.. Travis had that. But otherwise I think it's neat, we can live with it. |
Testing GH actions for CI