Parsoid: Remove support for stashing #1325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stashing is only needed by VisualEditor, and VisualEditor no longer uses RESTbase. So let's remove stashing from RESTbase. NOTE: This was made by blindly removing all code that refers to stashing. We need to carefully test this to make sure it doesn't break anything. Change-Id: I20aedf2206130c8d07f4419cf2dbf4dc349a2961
Change-Id: Ic6232a838f7ff0c995db4651b73446947fa2adc1
Change-Id: I67b3c22f96adad206ba19c9e6cf350b7dd70cab5
Change-Id: I625e69ea695502a549f2fdb258e9b597507790d6
Change-Id: I0df15b46736ceb73996be658bd751b179c5bf516
Change-Id: I35833cbc79d359910724e46a9d9e1b5d10366e2f
brightbyte
force-pushed
the
remove-stash
branch
from
1a2f5ca
to
eb17fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stashing is only needed by VisualEditor, and VisualEditor no longer uses RESTbase. So let's remove stashing from RESTbase.
NOTE: This was made by blindly removing all code that refers to stashing. We need to carefully test this to make sure it doesn't break anything.
Change-Id: I20aedf2206130c8d07f4419cf2dbf4dc349a2961