Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return URL regex to requiring http prefix #62

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

samwilson
Copy link
Member

This partially undoes the change in 78e773c and makes the http/https prefix required for image URLs. This is because protocol-relative URLs are now being changed to https in OcrController, so by the time the URL gets to the EngineBase it's no longer relative.

Bug: T324740

This partially undoes the change in 78e773c
and makes the http/https prefix required for image URLs.
This is because protocol-relative URLs are now being changed
to https in OcrController, so by the time the URL gets to the
EngineBase it's no longer relative.

Bug: T324740
@cimurah cimurah merged commit 47fe8be into main Jan 3, 2023
@cimurah cimurah deleted the revert-url-regex branch January 3, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants