Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Recommendations - Hide feature when VoiceOver is on #4821

Merged
merged 3 commits into from
Apr 25, 2024

Merge branch 'main' into image-recs-voiceover

341e8b5
Select commit
Failed to load commit list.
Merged

Image Recommendations - Hide feature when VoiceOver is on #4821

Merge branch 'main' into image-recs-voiceover
341e8b5
Select commit
Failed to load commit list.
Xcode Cloud / Wikipedia | Run Tests | Test - iOS (Wikipedia) succeeded Apr 25, 2024 in 10m 56s

19 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 19

Details

19 Warnings

Details

  Wikipedia/Code/ExploreViewController.swift:1205
      Immutable value 'articleURL' was never used; consider replacing with '_' or removing it
  Wikipedia/Code/UIViewController+FeatureComponentFactory.swift:31
      Initialization of immutable value 'title' was never used; consider replacing with assignment to '_' or removing it
  Components/Sources/Components/Components/Shared/Buttons/WKSmallMenuButton.swift:118
      'titleEdgeInsets' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration
  CoreData:1
      no NSValueTransformer with class name 'WMFSecureUnarchiveFromDataTransformer' was found for attribute 'object' on entity 'WMFContent'
  CoreData:1
      no NSValueTransformer with class name 'WMFSecureUnarchiveFromDataTransformer' was found for attribute 'value' on entity 'WMFKeyValue'
  Wikipedia/Code/UIViewController+FeatureComponentFactory.swift:54
      Initialization of immutable value 'learnMore' was never used; consider replacing with assignment to '_' or removing it
  CoreData:1
      no NSValueTransformer with class name 'WMFSecureUnarchiveFromDataTransformer' was found for attribute 'placemark' on entity 'WMFContentGroup'
  Components/Sources/Components/Components/Shared/Buttons/WKSmallMenuButton.swift:116
      'contentEdgeInsets' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration
  Wikipedia/Code/UIViewController+FeatureComponentFactory.swift:32
      Initialization of immutable value 'viewArticle' was never used; consider replacing with assignment to '_' or removing it
  SwiftLint not installed, run "scripts/brew_install" script to install
  Components/Sources/Components/Components/Shared/Buttons/WKSmallMenuButton.swift:109
      'adjustsImageWhenHighlighted' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration, you may customize to replicate this behavior via a configurationUpdateHandler
  Wikipedia/Code/ExploreViewController.swift:1206
      Immutable value 'wikitext' was never used; consider replacing with '_' or removing it
  Components/Sources/Components/Components/Shared/Buttons/WKSmallMenuButton.swift:115
      'titleEdgeInsets' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration
  CoreData:1
      no NSValueTransformer with class name 'WMFSecureUnarchiveFromDataTransformer' was found for attribute 'pageViews' on entity 'WMFArticle'
  Wikipedia/Code/WMFCurrentlyLoggedInUserFetcher.swift:65
      Value 'blockID' was defined but never used; consider replacing with boolean test
  Components/Sources/Components/Components/Shared/Buttons/WKSmallMenuButton.swift:119
      'contentEdgeInsets' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration
  CoreData:1
      no NSValueTransformer with class name 'WMFSecureUnarchiveFromDataTransformer' was found for attribute 'location' on entity 'WMFContentGroup'
  CoreData:1
      no NSValueTransformer with class name 'WMFSecureUnarchiveFromDataTransformer' was found for attribute 'messageLinks' on entity 'RemoteNotification'
  CoreData:1
      no NSValueTransformer with class name 'WMFSecureUnarchiveFromDataTransformer' was found for attribute 'contentPreview' on entity 'WMFContentGroup'

Annotations

Check notice on line 1205 in Wikipedia/Code/ExploreViewController.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Wikipedia | Run Tests | Test - iOS (Wikipedia)

Wikipedia/Code/ExploreViewController.swift#L1205 

Immutable value 'articleURL' was never used; consider replacing with '_' or removing it

Check notice on line 1206 in Wikipedia/Code/ExploreViewController.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Wikipedia | Run Tests | Test - iOS (Wikipedia)

Wikipedia/Code/ExploreViewController.swift#L1206 

Immutable value 'wikitext' was never used; consider replacing with '_' or removing it
View more details on Xcode Cloud