T363481: Use text-decoration for link style #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hueitan
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
NIce, this works!
I wondering myself why changing it to use ::after in my last commit
https://github.com/wikimedia/wikipedia-preview/pull/174/files
| opacity: 0.5; | ||
| border-bottom: 2px dashed; | ||
| text-decoration: dashed underline 2px; | ||
| text-decoration-color: rgba(0, 0, 0, 0.5); |
There was a problem hiding this comment.
Setting a color here doesn't look good in dark mode.
stephanebisson
pushed a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phab ticket: https://phabricator.wikimedia.org/T363481
Demo: https://wikimedia.github.io/wikipedia-preview/T363481-underline/articles/english.html
Wikipedia Preview links styling is currently implemented using a pseudo element (
::after). The following issues have been found to be likely due to this implementation:This PR uses
text-decorationinstead to fix issues above, sample below: