Release 3.6 #35
Open
Release 3.6 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Farina <matt.farina@suse.com> (cherry picked from commit 17ed9c4)
tweak basic handling - release 3.6 branch version
The URL passed to the getter for WithURL needs to be a full URL rather than a chart reference used at the CLI. For example, bitnami/wordpress can point to the wordpress chart in the bitnami repo where the bitnami repo is at https://charts.bitnami.com. WithURL needs the full URL to the repo and not bitnami/wordpress. This is important because getters use the full URL information. In this case the http getter uses the host name for SNI handling. Before this change WithURL was being set to the chart reference instead of the URL. This was a silent bug. This change sets WithURL using a URL after for the repo is available when a reference is used instead of a full url. Signed-off-by: Matt Farina <matt.farina@suse.com> (cherry picked from commit 4e2e408)
Signed-off-by: Matt Farina <matt.farina@suse.com> (cherry picked from commit 385fcae)
Signed-off-by: Christophe VILA <christophe.vila@thalesgroup.com> (cherry picked from commit 8232a76)
- add missing interface methods doc. - fix some wrong english grammar. Signed-off-by: longkai <im.longkai@gmail.com> (cherry picked from commit cf0c6fe)
…ulated in the requirements Signed-off-by: cndoit18 <cndoit18@outlook.com> (cherry picked from commit 402c7f1)
managedFields were a changed that landed in 1.18. This is an array under metadata with managedFields. The kubernetes client pkgs that Helm uses automatically add them. This change added a manager for the managedFields. The flow for deciding on the name to use is: 1. An explicit name if one is chosen 2. The base name of the first os.Arg (the binary name) if no name explicitly set. 3. unknown if no name set and name cannot be detected The name is at the package level as there is no other place to easily set it for Helm v3. Since the name is for the binary or app it should be ok to set app wide. Signed-off-by: Matt Farina <matt.farina@suse.com> (cherry picked from commit aeb9479)
Signed-off-by: Mathieu Parent <math.parent@gmail.com> (cherry picked from commit dbb4eb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Special notes for your reviewer:
If applicable: