[JBEAP-27509] extending history information

[spyrkob]

Add current manifest versions to the git commit so that they can be displayed in history operations

== Overview
The channel manifest 1.1.0 adds a notion of logicalVersion to separate the version of manifest from the Maven coordinate. This change will consume the new field falling back to the Maven coordinate (physical version) if the logicalVersion is not present.
Additionally, the PR changes how the manifest version information is stored. Previously the version string visible in history information was constructed during update and stored. This make it hard for API clients that would like to display the versions of individual manifests.

== Expected results

1. History operation on servers installed with old versions of Prospero works as previously
2. A newly provisioned server's history contains individual manifest's version information rather than the constructed version message
3. Installation-manger-api returns manifest version information for each history state including logical and physical version. If the commit was made before this changes, API should return commit information instead.

[spyrkob]

@TomasHofman could you review this when you have a moment?

[TomasHofman]

It's probably not very important, but since the manifest versions are involved in the equals method, should the collection type for versions be Set, rather than List?

(Thinking purely about ordering, which I assume is generally undefined - version collections should be equal if they contain the same elements, irrespective of order. I think Set would facilitate that.)

[spyrkob]

Good point, I'm going to sort the manifestVersions in the constructor. This way the ordering of the versions will be consistent in display.

[TomasHofman]

This would probably deserve a javadoc about what the logical and physical versions mean.

[TomasHofman]

To double check if this was intended, when I run the new history command against an old installation, I think it delegates to the old impl and shows something like this:

[thofman@rama prospero]$ ./prospero history --dir wf
[d0efe823] 2024-07-12T14:37:36Z - update [file:/home/thofman/Projects/prospero/manifest.yaml::a4ff586c9fce21976f8596c53d6247e200d22cc6]
[71420b8d] 2024-07-12T14:24:54Z - install [org.wildfly.channels:wildfly::33.0.0.Beta1]

It shows "install [G:A::version]" at the first record.

Running the command against a newly created installation, it doesn't show the GA anymore, just the version:

[thofman@rama prospero]$ ./prospero history --dir wf3
[7822a809] 2024-10-16T11:27:47Z - install [34.0.0.Beta1]

[TomasHofman]

High level question: since the original impl of the history command also shows versions of manifests, what is the intended improvement here?

[spyrkob]

Thanks @TomasHofman I updated the description to explain the changes. Let me know if that clarifies it.

Running the command against a newly created installation, it doesn't show the GA anymore, just the version:
That's my mistake, I'll fix that thanks

To double check if this was intended, when I run the new history command against an old installation, I think it delegates to the old impl and shows something like this
Correct, the old history states (made before this change) should be displayed as before

[TomasHofman]

OK, thanks for the explanation, I noticed the new schema version by accident but didn't know the details. Now it makes sense to me 👍 .

[spyrkob]

Thanks @TomasHofman 👍