Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-2745] Fix OIDC failures in testsuite on the 1.15.x branch #2129

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

Skyllarr
Copy link
Contributor

@Skyllarr Skyllarr commented Apr 15, 2024

@Skyllarr
Copy link
Contributor Author

Skyllarr commented Apr 15, 2024

@fjuma @ivassile These failures can be reproduced locally when docker is running. They are already present in 1.15.12.Final, we have to make sure we are running testsuite with docker available from now on so the tests are not skipped. It seems CI did not previously have docker available either so these tests were being skipped before.

When running the tests, the authentication passes successfully, but the keycloak returns by default the "Update Account Information" page after first login. But the tests expect the "Welcome page!" page instead, which would be returned after the required first and last name are configured.

This default behaviour is not happening on 2.x branch - the 2.x branch does not require user to configure first/last name after first login. I could not find any difference in the keycloak configuration between these 2 branches, so I am not sure why this behaviour is different. But since we should be tagging soon and this is a minor fix in tests, I think we can merge this as a solution now.

@Skyllarr Skyllarr requested review from ivassile and fjuma April 15, 2024 09:12
@ivassile ivassile added the +1 IV label Apr 15, 2024
@fjuma
Copy link
Contributor

fjuma commented Apr 15, 2024

Thanks @Skyllarr! Looks like the difference is the Keycloak version that gets used. For 2.x, we are currently using Keycloak 19.0.1 (https://github.com/wildfly-security/wildfly-elytron/blob/2.x/http/oidc/src/test/java/org/wildfly/security/http/oidc/KeycloakContainer.java#L33) but for 1.15.x, we are using the latest version (https://github.com/wildfly-security/wildfly-elytron/blob/1.15.22.Final/http/oidc/src/test/java/org/wildfly/security/http/oidc/KeycloakContainer.java#L33).

WildFly was recently updated to make use of Keycloak 24.0.1 (wildfly/wildfly@6ae189a) so we should update 1.15.x and 2.x to make use of this version as well. That could be done in this PR.

@Skyllarr
Copy link
Contributor Author

@fjuma I have previously tried a test PR to update keycloak to 18.0.2 but it did not help with these tests #2127 , I will try with the 24.0.1

@Skyllarr
Copy link
Contributor Author

@fjuma I see that the changes in the linked (wildfly/wildfly@6ae189a) also added first and last name, so i will leave it in this PR as well

@fjuma
Copy link
Contributor

fjuma commented Apr 15, 2024

@fjuma I see that the changes in the linked (wildfly/wildfly@6ae189a) also added first and last name, so i will leave it in this PR as well

Right, this is needed with the latest versions of Keycloak.

@Skyllarr
Copy link
Contributor Author

@fjuma This PR was updated to upgrade keycloak version

Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Skyllarr!

@fjuma fjuma merged commit 9613fad into wildfly-security:1.15.x Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants