[WFCORE-5640][WFCORE-5641] XSD and XML cleanup #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of making it an enum that must be updated with every WildFly Core release, let's use a string type. JIRA: https://issues.redhat.com/browse/WFCORE-5640 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Remove all DomainXml classes that were identical to their previous versions. This only leaves DomainXml classes that introduced actual changes to the XML parsing JIRA: https://issues.redhat.com/browse/WFCORE-5641 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Remove all StandaloneXml classes that were identical to their previous versions. This only leaves StandaloneXml classes that introduced actual changes to the XML parsing JIRA: https://issues.redhat.com/browse/WFCORE-5641 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Remove all HostXml classes that were identical to their previous versions. This only leaves HostXml classes that introduced actual changes to the XML parsing JIRA: https://issues.redhat.com/browse/WFCORE-5641 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil
force-pushed
the
WFCORE-5640_release_host-release_id_restriction
branch
from
567d42f
to
aa0fdfb
Compare
github-actions
bot
added
the
deps-ok
yersan
approved these changes
Oct 19, 2021
yersan
added
the
ready-for-merge
|
@yersan thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
[WFCORE-5640] Relax constraint on host-releaseType's id attribute
Instead of making it an enum that must be updated with every WildFly
Core release, let's use a string type.
JIRA: https://issues.redhat.com/browse/WFCORE-5640
[WFCORE-5641] Clean up DomainXml parser classes
Remove all WildFly core Xml classes that were identical to their previous
versions.
This only leaves classes that introduced actual changes to the
XML parsing
1 commit per XML class
JIRA: https://issues.redhat.com/browse/WFCORE-5641