Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-5685] KerberosHttpMgmtSaslTestCase & KerberosNativeMgmtSaslTestCase tests fail on JDK 18 EA #4850

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

rmartinc
Copy link
Contributor

@rmartinc rmartinc commented Nov 4, 2021

Issue: https://issues.redhat.com/browse/WFCORE-5685

The ldap/kerberos tests now also add all the enc-types defined in the keytab to the permitted_enctypes option in the krb5.conf file. This way the allowed enc-types don't depend on the default JDK values. Besides, previously the enc-types selected by the tests were different for ibm and non-ibm JDKs, this part has been also changed (don't know why but with non-ibm only two types were selected, this was done since the creation of the file).

Both tests pass for me with for jdk-18 and the current JDKs (I tried with a lot of versions and vendors).

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Nov 4, 2021
@wildfly-ci
Copy link

Core - Full Integration Build 11125 outcome was FAILURE using a merge of 75b0439
Summary: Tests passed: 7042, ignored: 129; exit code 1 (Step: Build & test full (Maven)) (new) Build time: 03:03:15

@rmartinc
Copy link
Contributor Author

@fjuma Remember this PR is waiting. It's just a minor change in the TS that adds all available mechanism to the kerberos setup. Thanks!

Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmartinc Thanks very much for the reminder and for working on this!

@darranl darranl added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Nov 25, 2021
@darranl darranl mentioned this pull request Nov 25, 2021
@darranl darranl merged commit 4942474 into wildfly:main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants