Add ModelTestControllerVersion for XP 4

[kabir]

https://issues.redhat.com/browse/WFCORE-5751

https://issues.redhat.com/browse/WFCORE-5752

[yersan]

It should be fine, although I don't understand at all why you added the WF Model descriptions for WF26 (wildfly/wildfly-legacy-test@ffab0be), indeed using a Beta1 release instead of a Final, and then you added the legacy controllers for WF25 (wildfly/wildfly-legacy-test@b214f32)

Probably they are the same but seems a bit misleading since we are getting here an enum that uses WF26 with WF25 controllers.

@kabir Is this configuration expected by you?

I would expect to have WF26 model descriptions based on a Final release on wildfly-legacy-test and WF26 subsystems and controllers instead of WF25, but I'm not sure about the intentions behind this.

[kabir]

Hi @yersan, there are a few parts to this:

• 26.0.0.Beta1 and 18.0.0.Final are the versions which will be used at runtime by the legacy controllers.
• 25.0.0 is the version of the legacy controller adapters to use (i.e. the subfolder in wildfly-legacy-test under core/ and subsystem/). These are compiled against a version of the controller API, but really the versions above specify what is pulled in for the legacy controller at runtime.

We introduce these adapters when there is a breaking change. In this case the breaking change was introduced with WildFly 25.0.0 where the VaultReader was removed from various server module APIs used by these server adapters.

I agree it is slightly confusing, but in the (very unlikely) case we would need transformers tests for WildFly 25 at some stage we can reuse the "25.0.0" versions. And if there are no breaking changes in the next few controller versions, we would be able to use an enum like the following for that:

FUTURE_RELEASE("28.0.0.Final", false, "25.0.0", "20.0.0.Final", "wf28")

So IMO it is correct.

Although, I see I have a typo on the following line:

 // EAP_XP_4("4.0.0.GA-redhat-0000x", true, "23.0.0", "18.0.0.Final-redhat-0000x", "xp4")

Here "23.0.0" should be "25.0.0", I'll replace that.

[kabir]

Or to put it another way, if the VaultReader had not been removed from the server in WildFly 25, we could have continued using the "23.0.0" adapters used in the previous EAP_7_4_0 version :-)

[yersan]

Ok, I understand. It was more natural to me to think more about even versions that belong all to the referred legacy version.

This legacy test framework still has a lot of unknown details to me, so I only commented on what I saw weirdly. If you are fine with the changes on wildfly-legacy-test and how they are brought in, I'm fine too.

[wildfly-ci]

Core - Full Integration Build 11290 outcome was FAILURE using a merge of bb6923f
Summary: Tests failed: 1 (1 new), passed: 7216, ignored: 140 Build time: 04:05:19

Failed tests

org.jboss.as.test.clustering.cluster.singleton.SingletonDeploymentJBossAllTestCase.test: java.lang.AssertionError: expected:<200> but was:<404>
	at org.jboss.as.test.clustering.cluster.singleton.SingletonDeploymentTestCase.test(SingletonDeploymentTestCase.java:130)
------- Stdout: -------
Warning! The CLI is running in a non-modular environment and cannot load commands from management extensions.
 [0m06:15:22,124 INFO  [org.jboss.as.connector.subsystems.datasources] (MSC service thread 1-1) WFLYJCA0010: Unbound data source [java:jboss/datasources/ExampleDS]
 [0m [0m06:15:22,124 INFO  [org.jboss.as.mail.extension] (MSC service thread 1-6) WFLYMAIL0002: Unbound mail session [java:jboss/mail/Default]
 [0m [0m06:15:22,126 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0008: Undertow HTTPS listener https suspending
 [0m [0m06:15:22,126 INFO  [org.jboss.modcluster] (ServerService Thread Pool -- 11) MODCLUSTER000002: Initiating mod_cluster shutdown
 [0m [0m06:15:22,127 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0008: Undertow AJP listener ajp suspending
 [0m [0m06:15:22,127 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0007: Undertow AJP listener ajp stopped, was bound to [::1]:8009
 [0m [0m06:15:22,127 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-5) WFLYUT0019: Host default-host stopping
 [0m [0m06:15:22,128 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0007: Undertow HTTPS listener https stopped, was bound to [::1]:8443
 [0m [33m06:15:22,128 WARN  [org.jboss.modcluster] (ServerService Thread Pool -- 11) MODCLUSTER000033: Failed to interrupt socket reception.: java.io.IOException: Invalid argument (sendto failed)
	at java.net.PlainDatagramSocketImpl.send(Native Method)
	at java.net.DatagramSocket.send(DatagramSocket.java:693)
	at org.jboss.modcluster.advertise.impl.AdvertiseListenerImpl.interruptDatagramReader(AdvertiseListenerImpl.java:197)
	at org.jboss.modcluster.advertise.impl.AdvertiseListenerImpl.stop(AdvertiseListenerImpl.java:212)
	at org.jboss.modcluster.advertise.impl.AdvertiseListenerImpl.destroy(AdvertiseListenerImpl.java:224)
	at org.jboss.modcluster.ModClusterService.shutdown(ModClusterService.java:199)
	at org.wildfly.extension.mod_cluster.ContainerEventHandlerServiceConfigurator.accept(ContainerEventHandlerServiceConfigurator.java:83)
	at org.wildfly.extension.mod_cluster.ContainerEventHandlerServiceConfigurator.accept(ContainerEventHandlerServiceConfigurator.java:50)
	at org.wildfly.clustering.service.FunctionalService.stop(FunctionalService.java:73)
	at org.wildfly.clustering.service.AsyncServiceConfigurator$AsyncService.lambda$stop$1(AsyncServiceConfigurator.java:142)
	at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
	at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
	at java.lang.Thread.run(Thread.java:748)
	at org.jboss.threads.JBossThread.run(JBossThread.java:513)

 [0m [0m06:15:22,131 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0008: Undertow HTTP listener default suspending
 [0m [0m06:15:22,131 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0007: Undertow HTTP listener default stopped, was bound to [::1]:8080
 [0m [0m06:15:22,133 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0004: Undertow 2.2.14.Final stopping
 [0m [0m06:15:22,143 INFO  [org.jboss.as.connector.deployers.jdbc] (MSC service thread 1-3) WFLYJCA0019: Stopped Driver service with driver-name = h2
 [0m [0m06:15:22,159 INFO  [org.jboss.as] (MSC service thread 1-6) WFLYSRV0050: WildFly Full 26.0.0.Final-SNAPSHOT (WildFly Core 19.0.0.Beta1-SNAPSHOT) stopped in 42ms
 [0m [0m06:15:22,161 INFO  [org.jboss.as] (MSC service thread 1-5) WFLYSRV0049: WildFly Full 26.0.0.Final-SNAPSHOT (WildFly Core 19.0.0.Beta1-SNAPSHOT) starting
 [0m [0m06:15:22,309 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m06:15:22,343 INFO  [org.wildfly.extension.elytron.oidc._private] (ServerService Thread Pool -- 55) WFLYOIDC0001: Activating WildFly Elytron OIDC Subsystem
 [0m [0m06:15:22,344 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 57) WFLYCLINF0001: Activating Infinispan subsystem.
 [0m [0m06:15:22,346 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 62) WFLYCLJG0001: Activating JGroups subsystem. JGroups version 4.2.11
 [0m [0m06:15:22,350 INFO  [org.wildfly.extension.microprofile.jwt.smallrye] (ServerService Thread Pool -- 69) WFLYJWT0001: Activating MicroProfile JWT Subsystem
 [0m [0m06:15:22,349 INFO  [org.wildfly.extension.microprofile.config.smallrye] (ServerService Thread Pool -- 68) WFLYCONF0001: Activating MicroProfile Config Subsystem
 [0m [0m06:15:22,351 INFO  [org.wildfly.extension.microprofile.opentracing] (ServerService Thread Pool -- 70) WFLYTRACEXT0001: Activating MicroProfile OpenTracing Subsystem
 [0m [0m06:15:22,352 INFO  [org.jboss.as.naming] (ServerService Thread Pool -- 72) WFLYNAM0001: Activating Naming Subsystem
 [0m [33m06:15:22,361 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 80) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.
 [0m [0m06:15:22,362 INFO  [org.jboss.as.webservices] (ServerService Thread Pool -- 82) WFLYWS0002: Activating WebServices Extension
 [0m [0m06:15:22,368 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 47) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 1.4)
 [0m [0m06:15:22,376 INFO  [org.wildfly.extension.health] (ServerService Thread Pool -- 56) WFLYHEALTH0001: Activating Base Health Subsystem
 [0m [0m06:15:22,378 INFO  [org.wildfly.extension.io] (ServerService Thread Pool -- 58) WFLYIO001: Worker 'default' has auto-configured to 8 IO threads with 64 max task threads based on your 4 available processors
 [0m [0m06:15:22,379 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 59) WFLYRS0016: RESTEasy version 4.7.4.Final
 [0m [0m06:15:22,379 INFO  [org.jboss.as.connector] (MSC service thread 1-3) WFLYJCA0009: Starting Jakarta Connectors Subsystem (WildFly/IronJacamar 1.5.3.Final)

[jmesnil]

@kabir thanks