Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6568] - Modify description in elytron subsystem #5729

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

gabrielpadilh4
Copy link
Contributor

@gabrielpadilh4 gabrielpadilh4 commented Oct 18, 2023

Modify description in elytron of subsystem to its correct sentence.

https://issues.redhat.com/browse/WFCORE-6568

@wildfly-ci
Copy link

Hello, gabrielpadilh4. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Oct 18, 2023
@yersan yersan changed the title [WFLY-16896] - Modify description in elytron subsystem [WFCORE-6568] - Modify description in elytron subsystem Oct 18, 2023
@yersan
Copy link
Collaborator

yersan commented Oct 18, 2023

Hello @gabrielpadilh4. Since this issue affects WildFly Core I've just moved it from WildFly. Consequently, the Jira number has changed, would you mind changing the commit message to include the new Jira (WFCORE-6568) and remove the obsolete one (WFLY-16896)? Thanks!

@gabrielpadilh4
Copy link
Contributor Author

gabrielpadilh4 commented Oct 18, 2023

Hello @yersan i changed the commit message. Thank you.

Can you please review ?

@yersan
Copy link
Collaborator

yersan commented Oct 19, 2023

/ok-to-test

Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielpadilh4
Copy link
Contributor Author

Hello @yersan i can't see why the job failed at team city, can you please review ?

@yersan
Copy link
Collaborator

yersan commented Oct 20, 2023

It was an execution timeout, so I kicked it off again, in any case, you can forget about the CI; your changes are harmless and unexpected to affect the testsuite.

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Oct 23, 2023
@yersan yersan merged commit 0688fd3 into wildfly:main Oct 23, 2023
12 checks passed
@yersan
Copy link
Collaborator

yersan commented Oct 23, 2023

Thanks @gabrielpadilh4

@gabrielpadilh4 gabrielpadilh4 deleted the WFLY-16882 branch October 23, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants