-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-6661] More accurate, resettable start time calculation #5827
Conversation
f0e17ce
to
21d38d5
Compare
Hello @bstansberry are you interested in getting this for WF23? |
@yersan Thanks for asking. No, this not urgent and shouldn't go in WF 31. It's a small foundation piece that's important for my prototyping at https://github.com/bstansberry/wildfly-core/commits/WildFly_CRaC, but that is just a research project. It's valid on it's own (it uses a more accurate JVM start time) so I went ahead and sent up the PR, but that benefit is quite minor and is not enough to justify doing it so late in the 31 work. |
host-controller/src/main/java/org/jboss/as/host/controller/HostControllerService.java
Outdated
Show resolved
Hide resolved
21d38d5
to
30d1528
Compare
Core -> Full Integration Build 13423 outcome was UNKNOWN using a merge of 30d1528 |
host-controller/src/main/java/org/jboss/as/host/controller/HostControllerService.java
Show resolved
Hide resolved
There has been no activity on this PR for 45 days. It will be auto-closed after 90 days. |
378dad0
to
a7d464b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There has been no activity on this PR for 45 days. It will be auto-closed after 90 days. |
98bd527
to
67aaf9e
Compare
Core -> Full Integration Build 13884 outcome was FAILURE using a merge of 1acec9d |
Core -> WildFly Preview Integration Build 13680 outcome was FAILURE using a merge of 1acec9d |
Core -> Full Integration Build 13609 outcome was FAILURE using a merge of 1acec9d |
Upss, I made a mistake by resolving the conflicts directly. |
Core -> Full Integration Build 13885 outcome was FAILURE using a merge of 6b05c02 |
Core -> WildFly Preview Integration Build 13681 outcome was FAILURE using a merge of 6b05c02 |
Core -> Full Integration Build 13610 outcome was FAILURE using a merge of 6b05c02 |
@yersan I rebased. |
Thanks @bstansberry |
https://issues.redhat.com/browse/WFCORE-6661
This encapsulates the existing and possible future (WFCORE-6657) behavior around calculating and resetting 'start time' in a class, instead of passing around primitive 'startTime' longs and doing math. It uses RuntimeMXBean for the original 'start time' of a non-embedded process, instead of using Module.getStartTime(), which is a time when JBoss Modules started, not when the JVM did.