Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6661] More accurate, resettable start time calculation #5827

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

bstansberry
Copy link
Contributor

@bstansberry bstansberry commented Jan 10, 2024

https://issues.redhat.com/browse/WFCORE-6661

This encapsulates the existing and possible future (WFCORE-6657) behavior around calculating and resetting 'start time' in a class, instead of passing around primitive 'startTime' longs and doing math. It uses RuntimeMXBean for the original 'start time' of a non-embedded process, instead of using Module.getStartTime(), which is a time when JBoss Modules started, not when the JVM did.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jan 10, 2024
@bstansberry bstansberry force-pushed the WFCORE-6661 branch 3 times, most recently from f0e17ce to 21d38d5 Compare January 10, 2024 07:59
@yersan yersan added the 24.x label Jan 10, 2024
@wildfly wildfly deleted a comment from wildfly-ci Jan 10, 2024
@bstansberry bstansberry added hold Do not merge this PR and removed 24.x labels Jan 11, 2024
@yersan
Copy link
Collaborator

yersan commented Jan 12, 2024

Hello @bstansberry are you interested in getting this for WF23?

@bstansberry
Copy link
Contributor Author

@yersan Thanks for asking. No, this not urgent and shouldn't go in WF 31. It's a small foundation piece that's important for my prototyping at https://github.com/bstansberry/wildfly-core/commits/WildFly_CRaC, but that is just a research project. It's valid on it's own (it uses a more accurate JVM start time) so I went ahead and sent up the PR, but that benefit is quite minor and is not enough to justify doing it so late in the 31 work.

@wildfly-ci
Copy link

Core -> Full Integration Build 13423 outcome was UNKNOWN using a merge of 30d1528
Summary: Canceled (Tests passed: 7515, ignored: 101; exit code 143 (Step: Build & test full (Maven)) (new)) Build time: 03:36:38

@bstansberry bstansberry added the hold Do not merge this PR label Feb 10, 2024
Copy link

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

@github-actions github-actions bot added the Stale label Mar 26, 2024
@bstansberry bstansberry force-pushed the WFCORE-6661 branch 3 times, most recently from 378dad0 to a7d464b Compare March 29, 2024 00:25
@github-actions github-actions bot removed the Stale label Mar 29, 2024
@wildfly-ci

This comment was marked as outdated.

@yersan yersan removed the 24.x label Apr 1, 2024
Copy link

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

@github-actions github-actions bot added the Stale label May 17, 2024
@bstansberry bstansberry force-pushed the WFCORE-6661 branch 2 times, most recently from 98bd527 to 67aaf9e Compare June 13, 2024 22:13
@bstansberry bstansberry removed the hold Do not merge this PR label Jun 13, 2024
@github-actions github-actions bot removed the Stale label Jun 14, 2024
@wildfly-ci
Copy link

Core -> Full Integration Build 13884 outcome was FAILURE using a merge of 1acec9d
Summary: Compilation error: Compiler (new) Build time: 00:01:03

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 13680 outcome was FAILURE using a merge of 1acec9d
Summary: Compilation error: Compiler (new) Build time: 00:01:05

@wildfly-ci
Copy link

Core -> Full Integration Build 13609 outcome was FAILURE using a merge of 1acec9d
Summary: Compilation error: Compiler (new) Build time: 00:01:06

@yersan
Copy link
Collaborator

yersan commented Jun 20, 2024

Upss, I made a mistake by resolving the conflicts directly.

@wildfly-ci
Copy link

Core -> Full Integration Build 13885 outcome was FAILURE using a merge of 6b05c02
Summary: Compilation error: Compiler (new) Build time: 00:00:43

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 13681 outcome was FAILURE using a merge of 6b05c02
Summary: Compilation error: Compiler (new) Build time: 00:00:49

@wildfly-ci
Copy link

Core -> Full Integration Build 13610 outcome was FAILURE using a merge of 6b05c02
Summary: Compilation error: Compiler (new) Build time: 00:00:53

@bstansberry
Copy link
Contributor Author

@yersan I rebased.

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jul 2, 2024
@yersan yersan merged commit d2a7ba4 into wildfly:main Jul 8, 2024
12 checks passed
@yersan
Copy link
Collaborator

yersan commented Jul 8, 2024

Thanks @bstansberry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants