Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for #49 and #50 #51

Merged
merged 11 commits into from
May 9, 2018
Merged

fixes for #49 and #50 #51

merged 11 commits into from
May 9, 2018

Conversation

willmcgugan
Copy link
Contributor

@willmcgugan willmcgugan commented May 8, 2018 •
edited
Loading

What this PR solves

Review

  • Ready for review

gmyers18
gmyers18 approved these changes May 9, 2018
View reviewed changes
Copy link

@gmyers18 gmyers18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly making these fixes. I tested the PR and it resolves both issues I was running into.

The docstring for WebSocket.sent_close_time() needs to be updated to reflect session time rather than epoch time.

@willmcgugan willmcgugan merged commit 2e9924e into master May 9, 2018
@willmcgugan willmcgugan deleted the fix-graceful-clos branch May 9, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmyers18 gmyers18 gmyers18 approved these changes

@barfle barfle barfle approved these changes

@stuartkmarsh stuartkmarsh Awaiting requested review from stuartkmarsh

@toudi toudi Awaiting requested review from toudi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willmcgugan @barfle @gmyers18