Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add link to node terminate description #22

Merged
merged 3 commits into from
Oct 1, 2018
Merged

docs: add link to node terminate description #22

merged 3 commits into from
Oct 1, 2018

Conversation

larshp
Copy link
Contributor

@larshp larshp commented Sep 30, 2018

docs: add link to node terminate description

Also, the section says "Graceful shutdown", I'd consider it to be forceful shutdown 🤷‍♂️

@coveralls
Copy link

coveralls commented Sep 30, 2018

Pull Request Test Coverage Report for Build 16

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.872%

Totals Coverage Status
Change from base Build 11: 0.0%
Covered Lines: 84
Relevant Lines: 87

💛 - Coveralls

@wilk
Copy link
Owner

wilk commented Oct 1, 2018

Thanks for this PR!
Yes, I do agree: Forceful Shutdown sounds better 😄
Would you like to update this PR?

@larshp
Copy link
Contributor Author

larshp commented Oct 1, 2018

updated, changed to "Force shutdown", sounds better IMHO than my first suggestion

@wilk
Copy link
Owner

wilk commented Oct 1, 2018

updated, changed to "Force shutdown", sounds better IMHO than my first suggestion

I'd like to stick to "Forceful Shutdown" instead of "Force Shutdown" (it sounds like an action instead of a title), what do you think?

@larshp
Copy link
Contributor Author

larshp commented Oct 1, 2018

updated

@wilk wilk merged commit 02b8e8f into wilk:master Oct 1, 2018
@wilk
Copy link
Owner

wilk commented Oct 1, 2018

Thanks! 💪

@larshp larshp deleted the patch-1 branch October 1, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants