Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggplot2 3.4.0 warning for size vs linewidth #78

Closed
jthomasmock opened this issue Nov 17, 2022 · 3 comments · Fixed by #80
Closed

ggplot2 3.4.0 warning for size vs linewidth #78

jthomasmock opened this issue Nov 17, 2022 · 3 comments · Fixed by #80

Comments

@jthomasmock
Copy link
Contributor

jthomasmock commented Nov 17, 2022 •
edited
Loading

The size argument for the geom_vline internals of ridges is throwing a warning now that ggplot2 has a linewidth argument and deprecated size.

library(ggplot2)
library(ggridges)

mtcars |>
  ggplot() +
  geom_density_ridges(
    aes(x = mpg, y = cyl, group = cyl),
    quantile_lines = TRUE,
    quantiles = 2,
    size = 0.5
  )
#> Picking joint bandwidth of 1.38
#> Warning: Using the `size` aesthietic with geom_segment was deprecated in ggplot2 3.4.0.
#> ℹ Please use the `linewidth` aesthetic instead.

sessioninfo::session_info(pkgs = "loaded")
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value
#>  version  R version 4.2.0 (2022-04-22)
#>  os       macOS Monterey 12.6
#>  system   aarch64, darwin20
#>  ui       X11
#>  language (EN)
#>  collate  en_US.UTF-8
#>  ctype    en_US.UTF-8
#>  tz       America/Chicago
#>  date     2022-11-17
#>  pandoc   2.19.2 @ /Applications/RStudio.app/Contents/Resources/app/quarto/bin/tools/ (via rmarkdown)
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version     date (UTC) lib source
#>  assertthat    0.2.1       2019-03-21 [1] CRAN (R 4.2.0)
#>  cli           3.4.1       2022-09-23 [1] CRAN (R 4.2.0)
#>  colorspace    2.0-3       2022-02-21 [1] CRAN (R 4.2.0)
#>  DBI           1.1.3       2022-06-18 [1] CRAN (R 4.2.0)
#>  digest        0.6.30      2022-10-18 [1] CRAN (R 4.2.0)
#>  dplyr         1.0.10      2022-09-01 [1] CRAN (R 4.2.0)
#>  evaluate      0.16        2022-08-09 [1] CRAN (R 4.2.0)
#>  fansi         1.0.3       2022-03-24 [1] CRAN (R 4.2.0)
#>  farver        2.1.1       2022-07-06 [1] CRAN (R 4.2.0)
#>  fastmap       1.1.0       2021-01-25 [1] CRAN (R 4.2.0)
#>  fs            1.5.2       2021-12-08 [1] CRAN (R 4.2.0)
#>  generics      0.1.3       2022-07-05 [1] CRAN (R 4.2.0)
#>  ggplot2     * 3.4.0       2022-11-04 [1] CRAN (R 4.2.0)
#>  ggridges    * 0.5.4       2022-11-17 [1] Github (wilkelab/ggridges@add4f72)
#>  glue          1.6.2       2022-02-24 [1] CRAN (R 4.2.0)
#>  gtable        0.3.1       2022-09-01 [1] CRAN (R 4.2.0)
#>  highr         0.9         2021-04-16 [1] CRAN (R 4.2.0)
#>  htmltools     0.5.3       2022-07-18 [1] CRAN (R 4.2.0)
#>  knitr         1.40        2022-08-24 [1] CRAN (R 4.2.0)
#>  labeling      0.4.2       2020-10-20 [1] CRAN (R 4.2.0)
#>  lifecycle     1.0.3       2022-10-07 [1] CRAN (R 4.2.0)
#>  magrittr      2.0.3       2022-03-30 [1] CRAN (R 4.2.0)
#>  munsell       0.5.0       2018-06-12 [1] CRAN (R 4.2.0)
#>  pillar        1.8.1       2022-08-19 [1] CRAN (R 4.2.0)
#>  pkgconfig     2.0.3       2019-09-22 [1] CRAN (R 4.2.0)
#>  purrr         0.3.5       2022-10-06 [1] CRAN (R 4.2.0)
#>  R.cache       0.15.0      2021-04-30 [1] CRAN (R 4.2.0)
#>  R.methodsS3   1.8.1       2020-08-26 [1] CRAN (R 4.2.0)
#>  R.oo          1.24.0      2020-08-26 [1] CRAN (R 4.2.0)
#>  R.utils       2.11.0      2021-09-26 [1] CRAN (R 4.2.0)
#>  R6            2.5.1       2021-08-19 [1] CRAN (R 4.2.0)
#>  reprex        2.0.1       2021-08-05 [1] CRAN (R 4.2.0)
#>  rlang         1.0.6       2022-09-24 [1] CRAN (R 4.2.0)
#>  rmarkdown     2.14        2022-04-25 [1] CRAN (R 4.2.0)
#>  rstudioapi    0.14.0-9000 2022-09-01 [1] local
#>  scales        1.2.1       2022-08-20 [1] CRAN (R 4.2.0)
#>  sessioninfo   1.2.2       2021-12-06 [1] CRAN (R 4.2.0)
#>  stringi       1.7.8       2022-07-11 [1] CRAN (R 4.2.0)
#>  stringr       1.4.1       2022-08-20 [1] CRAN (R 4.2.0)
#>  styler        1.8.1       2022-11-07 [1] CRAN (R 4.2.0)
#>  tibble        3.1.8       2022-07-22 [1] CRAN (R 4.2.0)
#>  tidyselect    1.2.0.9000  2022-11-16 [1] Github (r-lib/tidyselect@b449033)
#>  utf8          1.2.2       2021-07-24 [1] CRAN (R 4.2.0)
#>  vctrs         0.5.1       2022-11-16 [1] CRAN (R 4.2.0)
#>  withr         2.5.0       2022-03-03 [1] CRAN (R 4.2.0)
#>  xfun          0.33        2022-09-12 [1] CRAN (R 4.2.0)
#>  yaml          2.3.5       2022-02-21 [1] CRAN (R 4.2.0)
#> 
#>  [1] /Library/Frameworks/R.framework/Versions/4.2-arm64/Resources/library
#> 
#> ──────────────────────────────────────────────────────────────────────────────

Created on 2022-11-17 by the reprex package (v2.0.1)

Warning message:
Using the `size` aesthietic with geom_segment
was deprecated in ggplot2 3.4.0.
ℹ Please use the `linewidth` aesthetic instead.
This warning is displayed once every 8 hours.
Call `lifecycle::last_lifecycle_warnings()` to
see where this warning was generated. 
[15:45 💻 @main]> lifecycle::last_lifecycle_warnings()
[[1]]
<warning/lifecycle_warning_deprecated>
Warning:
Using the `size` aesthietic with geom_segment
was deprecated in ggplot2 3.4.0.
ℹ Please use the `linewidth` aesthetic instead.
---
Backtrace:
  1. base (local) `<fn>`(x)
  2. ggplot2:::print.ggplot(x)
  4. ggplot2:::ggplot_gtable.ggplot_built(data)
  5. ggplot2:::by_layer(...)
 12. ggplot2 (local) f(l = layers[[i]], d = data[[i]])
 13. l$draw_geom(d, layout)
 14. ggplot2 (local) draw_geom(..., self = self)
 15. self$geom$draw_layer(...)
 16. ggplot2 (local) draw_layer(..., self = self)
 17. base::lapply(...)
 18. ggplot2 (local) FUN(X[[i]], ...)
 20. self$draw_panel(data, panel_params, coord, na.rm = FALSE)
 21. ggridges (local) draw_panel(..., self = self)
 22. base::lapply(...)
 23. ggridges (local) FUN(X[[i]], ...)
 24. self$draw_group(group, panel_params, coord, ...)
 25. ggridges (local) draw_group(..., self = self)
 26. self$make_vline_grob(data_list[["vline"]], panel_params, coord)
 27. ggridges (local) make_vline_grob(...)
 28. ggplot2::GeomSegment$draw_panel(data, panel_params, coord)
 29. ggplot2 (local) draw_panel(..., self = self)
 30. ggplot2:::check_linewidth(data, snake_class(self))
 31. ggplot2:::deprecate_soft0(...)
@clauswilke
Copy link
Collaborator

Thanks for the report. I agree, needs to be fixed. If you'd like to make a PR you're definitely welcome to do so.

This was referenced Nov 17, 2022
Closed
Merged
@jthomasmock
Copy link
Contributor Author

Put together a broader PR to fix a few deprecation warnings and correct some tests. It's passing R CMD CHECK and testthat locally, but if you want to review the PR and allow for automated testing I can make revisions.

@jthomasmock
Copy link
Contributor Author

Fixed in latest PR.

library(ggplot2)
library(ggridges)

mtcars |>
  ggplot() +
  geom_density_ridges(
    aes(x = mpg, y = cyl, group = cyl),
    quantile_lines = TRUE,
    quantiles = 2,
    linewidth = 1.5
  )
#> Picking joint bandwidth of 1.38

sessioninfo::session_info(pkgs = "loaded")
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value
#>  version  R version 4.2.0 (2022-04-22)
#>  os       macOS Monterey 12.6
#>  system   aarch64, darwin20
#>  ui       X11
#>  language (EN)
#>  collate  en_US.UTF-8
#>  ctype    en_US.UTF-8
#>  tz       America/Chicago
#>  date     2022-11-18
#>  pandoc   2.19.2 @ /Applications/RStudio.app/Contents/Resources/app/quarto/bin/tools/ (via rmarkdown)
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version     date (UTC) lib source
#>  cli           3.4.1       2022-09-23 [1] CRAN (R 4.2.0)
#>  colorspace    2.0-3       2022-02-21 [1] CRAN (R 4.2.0)
#>  digest        0.6.30      2022-10-18 [1] CRAN (R 4.2.0)
#>  dplyr         1.0.99.9000 2022-11-18 [1] Github (tidyverse/dplyr@0a55cf5)
#>  evaluate      0.16        2022-08-09 [1] CRAN (R 4.2.0)
#>  fansi         1.0.3       2022-03-24 [1] CRAN (R 4.2.0)
#>  farver        2.1.1       2022-07-06 [1] CRAN (R 4.2.0)
#>  fastmap       1.1.0       2021-01-25 [1] CRAN (R 4.2.0)
#>  fs            1.5.2       2021-12-08 [1] CRAN (R 4.2.0)
#>  generics      0.1.3       2022-07-05 [1] CRAN (R 4.2.0)
#>  ggplot2     * 3.4.0       2022-11-04 [1] CRAN (R 4.2.0)
#>  ggridges    * 0.5.5       2022-11-18 [1] local
#>  glue          1.6.2       2022-02-24 [1] CRAN (R 4.2.0)
#>  gtable        0.3.1       2022-09-01 [1] CRAN (R 4.2.0)
#>  highr         0.9         2021-04-16 [1] CRAN (R 4.2.0)
#>  htmltools     0.5.3       2022-07-18 [1] CRAN (R 4.2.0)
#>  knitr         1.40        2022-08-24 [1] CRAN (R 4.2.0)
#>  labeling      0.4.2       2020-10-20 [1] CRAN (R 4.2.0)
#>  lifecycle     1.0.3       2022-10-07 [1] CRAN (R 4.2.0)
#>  magrittr      2.0.3       2022-03-30 [1] CRAN (R 4.2.0)
#>  munsell       0.5.0       2018-06-12 [1] CRAN (R 4.2.0)
#>  pillar        1.8.1       2022-08-19 [1] CRAN (R 4.2.0)
#>  pkgconfig     2.0.3       2019-09-22 [1] CRAN (R 4.2.0)
#>  purrr         0.3.5       2022-10-06 [1] CRAN (R 4.2.0)
#>  R.cache       0.15.0      2021-04-30 [1] CRAN (R 4.2.0)
#>  R.methodsS3   1.8.1       2020-08-26 [1] CRAN (R 4.2.0)
#>  R.oo          1.24.0      2020-08-26 [1] CRAN (R 4.2.0)
#>  R.utils       2.11.0      2021-09-26 [1] CRAN (R 4.2.0)
#>  R6            2.5.1       2021-08-19 [1] CRAN (R 4.2.0)
#>  reprex        2.0.1       2021-08-05 [1] CRAN (R 4.2.0)
#>  rlang         1.0.6       2022-09-24 [1] CRAN (R 4.2.0)
#>  rmarkdown     2.14        2022-04-25 [1] CRAN (R 4.2.0)
#>  rstudioapi    0.14.0-9000 2022-09-01 [1] local
#>  scales        1.2.1       2022-08-20 [1] CRAN (R 4.2.0)
#>  sessioninfo   1.2.2       2021-12-06 [1] CRAN (R 4.2.0)
#>  stringi       1.7.8       2022-07-11 [1] CRAN (R 4.2.0)
#>  stringr       1.4.1       2022-08-20 [1] CRAN (R 4.2.0)
#>  styler        1.8.1       2022-11-07 [1] CRAN (R 4.2.0)
#>  tibble        3.1.8       2022-07-22 [1] CRAN (R 4.2.0)
#>  tidyselect    1.2.0.9000  2022-11-16 [1] Github (r-lib/tidyselect@b449033)
#>  utf8          1.2.2       2021-07-24 [1] CRAN (R 4.2.0)
#>  vctrs         0.5.1       2022-11-16 [1] CRAN (R 4.2.0)
#>  withr         2.5.0       2022-03-03 [1] CRAN (R 4.2.0)
#>  xfun          0.33        2022-09-12 [1] CRAN (R 4.2.0)
#>  yaml          2.3.5       2022-02-21 [1] CRAN (R 4.2.0)
#> 
#>  [1] /Library/Frameworks/R.framework/Versions/4.2-arm64/Resources/library
#> 
#> ──────────────────────────────────────────────────────────────────────────────

Created on 2022-11-18 by the reprex package (v2.0.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@clauswilke @jthomasmock