Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hotkey): allow hotkey with commas #22

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

willianrod
Copy link
Owner

Issue #19

Each binding is an array of keys. To show it, the input was using join(",") to show it formatted. This was causing an issue because when submitting the form split(',') was required. So when splitting "," was resulting in ["", ""]

Solution

To fix it I just removed split and join because it was not required

@willianrod willianrod added bug Something isn't working approved labels Aug 21, 2023
@willianrod willianrod merged commit 0b2cd56 into main Aug 23, 2023
@willianrod willianrod deleted the fix-comma-keybind branch August 27, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant