Feat: Delete Device function #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added - Button to delete devices - Delete device function - Modal to confirm delete - translations
Closed
willianrod
reviewed
Aug 22, 2023
|
@fireblaze267 Just a single comment, everything else seems great. I didn't have time to run it locally to verify the functionality yet, but I'll do it today |
|
I uploaded a new version where I delete the pages and keys, thanks for the feedback |
willianrod
requested changes
Aug 23, 2023
- adding type in prop - getting just the prop of the component - translation fix
|
Thanks for the feedback, I've just uploaded a new version with the suggestions |
willianrod
requested changes
Aug 24, 2023
willianrod
approved these changes
Aug 24, 2023
|
@fireblaze267 thanks for your contribution ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First time with this
Added